Minor bugfixes #635
Open
Minor bugfixes #635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skipped during the symbol table input step
when encountering an unsupported machine type
It appears that keyboard input with the ALT key held does not trigger WM_CHAR events (only WM_SYSCHAR events). Moreover, the win32 documentation states that bit 29 (zero-based indexing) is used to indicate if ALT is held. This would correspond to `bit30`, not `bit29`, as these constant names use one-based indexing. This makes it clear that the conditions in the deleted code were never hit, in any circumstance.
The win32 documentation for InitializeCriticalSection makes it clear that DeleteCriticalSection must be called to clear up resources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One minor arch cracking change, two small win32 fixes. Commit messages should explain details.
I don't believe this project targets ARM platforms right now, and
os_mutex_releasedoesn't seem to be called anywhere, so the arch cracking change and the mutex fix shouldn't have a noticeable impact at the moment.The "ALT key during WM_CHAR events" commit removes dead code and avoids conditionally acting on an lParam bit that is marked as reserved in the win32 docs (empirically appears to always be 0 - so no observable effects).