Skip to content

AST parser libs history #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 13, 2023
Merged

Conversation

shayne-fletcher
Copy link
Collaborator

provide a little more color to the Background, Prior Art section.

@shayne-fletcher shayne-fletcher force-pushed the ast-parser-libs-history branch 3 times, most recently from 357d11b to 8ea8a1c Compare August 13, 2023 17:41
@shayne-fletcher shayne-fletcher force-pushed the ast-parser-libs-history branch from 8ea8a1c to 5bf9d91 Compare August 13, 2023 17:42

Today, most users of |haskell-src-exts| have largely migrated from |haskell-src-exts| to |ghc-lib-parser| [#exampleghclibparserusers]_.
But just because all these projects are using |ghc-lib-parser| doesn't mean everything is well.
**Insert quote about maintainence overhead.**
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking of what you put in the email to me about how much time the "ghc-lib-parser/ghc-lib/ghc-lib-parser-ex/hlint stack" was costing you, @shayne-fletcher.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's kind of you john. feel free to adapt "(ghc-lib-parser related maintenance) generally costs an hour or two a week and often more" in any way you see fit!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not just kind, it is crucial evidence the modularity question isn't just an abstract one of code quality / library friendliness, but also a concrete one of reducing wasteful costs that you are stuck paying today!

Copy link
Owner

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that with your addition of the chronology of events, the ghc-lib-parser section heading no longer was where that library was introduced.

I thought about it, and it seemed like the only way to fix the topical separation of the sections while not messing up the chronology was to put HLint's story and its chronology in its own section. I then just went ahead and did, and added some text of why HLint has a "flagship" and frequent "guinea pig", is notable beyond just its status as a widely used project.

Let me know what you think @shayne-fletcher; feel free to disagree with that reorg, make some more changes, or just hit the merge button. :)

@shayne-fletcher shayne-fletcher merged commit 2fcbad5 into ast-parser-libs Aug 13, 2023
@shayne-fletcher shayne-fletcher deleted the ast-parser-libs-history branch August 13, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants