-
Notifications
You must be signed in to change notification settings - Fork 2
AST parser libs history #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
357d11b
to
8ea8a1c
Compare
8ea8a1c
to
5bf9d91
Compare
This makes the diff easier to read with (crude, bad for prose) line-based diffing.
|
||
Today, most users of |haskell-src-exts| have largely migrated from |haskell-src-exts| to |ghc-lib-parser| [#exampleghclibparserusers]_. | ||
But just because all these projects are using |ghc-lib-parser| doesn't mean everything is well. | ||
**Insert quote about maintainence overhead.** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking of what you put in the email to me about how much time the "ghc-lib-parser/ghc-lib/ghc-lib-parser-ex/hlint stack" was costing you, @shayne-fletcher.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's kind of you john. feel free to adapt "(ghc-lib-parser related maintenance) generally costs an hour or two a week and often more" in any way you see fit!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not just kind, it is crucial evidence the modularity question isn't just an abstract one of code quality / library friendliness, but also a concrete one of reducing wasteful costs that you are stuck paying today!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that with your addition of the chronology of events, the ghc-lib-parser section heading no longer was where that library was introduced.
I thought about it, and it seemed like the only way to fix the topical separation of the sections while not messing up the chronology was to put HLint's story and its chronology in its own section. I then just went ahead and did, and added some text of why HLint has a "flagship" and frequent "guinea pig", is notable beyond just its status as a widely used project.
Let me know what you think @shayne-fletcher; feel free to disagree with that reorg, make some more changes, or just hit the merge button. :)
provide a little more color to the Background, Prior Art section.