fix bugs in order to use easily #23

shizhongpwn · 2021-09-08T11:49:14Z

because othre program update , this project have some error, and i change it to user python3, and fix iterm2 bugs in macos.

Escapingbug

Thanks for your pull request! But there's something I found that may need some cleanup.

Escapingbug · 2021-09-08T11:51:19Z

README.md

@@ -61,7 +59,7 @@ Current official backends:
 Current official terminals:

 - [ancypwn-terminal-alacritty](https://github.com/Escapingbug/ancypwn-terminal-alacritty)
- [ancypwn-terminal-iterm2](https://github.com/Escapingbug/ancypwn-terminal-iterm2)
+- [ancypwn-terminal-iterm2](https://github.com/shizhongpwn/ancypwn-terminal-iterm2.git)


What is the problem with the current solution? If you please, you might fire an PR to that repo as well instead of just replacing the "official" one?

Escapingbug · 2021-09-08T11:51:42Z

README.md


 pip3 install ancypwn
-# pip3 install ancypwn-backend-* (choose your backend, and install it)
-# pip3 install ancypwn-terminal-* (choose your terminal, and install it)
+# install ancypwn-backend-* (choose your backend, and install it)


Why is the "pip3" missing exactly?

becauser it can't download through pip3.

Escapingbug · 2021-09-08T11:52:03Z

ancypwn-docker/16.04/.gdb_history

@@ -0,0 +1 @@
+parseheap 


I think this is a mistake..?

Escapingbug · 2021-09-08T11:52:30Z

ancypwn-docker/20.04/.gdb_history

@@ -0,0 +1 @@
+parseheap 


This one as well

Escapingbug · 2021-09-08T11:53:10Z

ancypwn-terminal/launch.json

@@ -0,0 +1,16 @@
+{


This file should not be uploaded.

Escapingbug · 2021-09-08T11:53:47Z

src/ancypwn.py

 ]


-system = platform.system().lower()
-if 'linux' in system or 'darwin' in system:
+system = platform.system().lower() 


Hopefully, you could deal with the trailing whitespace.

Escapingbug · 2021-09-08T11:54:16Z

src/server.py

@@ -5,6 +5,8 @@
 import importlib
 from socketserver import TCPServer, StreamRequestHandler

+class PluginNotFoundError(Exception):


Is this used?

shizhongpwn · 2021-09-08T12:10:44Z

i already fixed

Escapingbug

And one more thing, why do we have those submodules present? Are those neccessary?

Escapingbug · 2021-09-09T06:15:03Z

src/server.py

        content = json.loads(json_content)
-        terminal = content['terminal']
-        if content['exec'] != '':
+        terminal = content['terminal'] 


sadly the trailing whitespace is still present

ok, i already kown and delete it.

Escapingbug · 2022-01-11T02:46:36Z

ancypwn-docker/16.04/Dockerfile

+    cd ~ && tar -xvf /usr/src/glibc/glibc-2.23.tar.xz
+
+# python/ruby packages & gdb-plugin
+#RUN wget https://files.pythonhosted.org/packages/cd/82/04e9aaf603fdbaecb4323b9e723f13c92c245f6ab2902195c53987848c78/pip-21.1.2-py3-none-any.whl && \


Is this line of comment useful or we can just remove it away?

Escapingbug · 2022-01-11T02:47:06Z

ancypwn-docker/16.04/Dockerfile

+
+# python/ruby packages & gdb-plugin
+#RUN wget https://files.pythonhosted.org/packages/cd/82/04e9aaf603fdbaecb4323b9e723f13c92c245f6ab2902195c53987848c78/pip-21.1.2-py3-none-any.whl && \
+#RUN pip3 install pip-21.1.2-py3-none-any.whl && \


If those comments are not needed, please remove them to keep the codebase clean.

Escapingbug · 2022-01-11T02:48:05Z

ancypwn-terminal/ancyterm.py

@@ -10,32 +11,28 @@ def pack(num):
    return struct.pack('<I', num)


+# 这个主要是用来传递终端参数的,执行的命令，和选择的终端信息。


Please use English if you tend to keep this comment.

Escapingbug · 2022-01-11T02:48:18Z

ancypwn-terminal/ancyterm.py

-    sock.connect((args.server, port))
-
-    sock.sendall(protocol_msg)
+    sock.connect((args.server, port)) #连接服务器


The same as before.

Escapingbug · 2022-01-11T02:48:52Z

src/ancypwn.py

@@ -40,7 +40,7 @@
    install_plugin_name = 'windows'


-DEFAULT_CONFIG = {
+DEFAULT_CONFIG = { 


trailing space

shizhongpwn added 11 commits June 29, 2021 11:26

docker update

b2f9ee3

ancypwn-terminal update

88f8b6e

src update to py3

f20286e

macos

469a382

README

e73e461

ancypwn-terminal2 update

8459c4b

docker 20.04

4a5db27

README

8f83700

ancypwn-docker update

67b9d78

ancypwn-terminal update

9954b74

src update

f6f69e2

Escapingbug requested changes Sep 8, 2021

View reviewed changes

shizhongpwn added 4 commits September 8, 2021 20:07

ancypwn-docker update

44a2ba6

ancypwn-terminal update

a67ed26

src update

1b99c04

README

653b0a4

README

c18ac4c

Escapingbug requested changes Sep 9, 2021

View reviewed changes

delete the whitespace in server.py

716146e

Escapingbug reviewed Jan 11, 2022

View reviewed changes

src/ancypwn.py

@@ -40,7 +40,7 @@

install_plugin_name = 'windows'

DEFAULT_CONFIG = {

DEFAULT_CONFIG = {

Copy link

Owner

Escapingbug Jan 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing space

		@@ -10,32 +11,28 @@ def pack(num):
		return struct.pack('<I', num)


		# 这个主要是用来传递终端参数的,执行的命令，和选择的终端信息。

		@@ -0,0 +1 @@
		parseheap

		@@ -0,0 +1 @@
		parseheap

fix bugs in order to use easily #23

Are you sure you want to change the base?

fix bugs in order to use easily #23

Uh oh!

Conversation

shizhongpwn commented Sep 8, 2021

Uh oh!

Escapingbug left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shizhongpwn commented Sep 8, 2021

Uh oh!

Escapingbug left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!