Skip to content

Correção do envio de variáveis pelo typeboy #1624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2025

Conversation

matheusfterra
Copy link

@matheusfterra matheusfterra commented Jun 19, 2025

Atualmente quando no fluxo do typebot tem o envio de alguma variável, a mensagem não é enviada.

Com essa correção a mensagem é enviada normalmente.

Summary by Sourcery

Bug Fixes:

  • Bind applyFormatting to the service instance when processing Typebot messages to fix variable sending

Copy link
Contributor

sourcery-ai bot commented Jun 19, 2025

Reviewer's Guide

The PR fixes a context-binding issue by passing a bound version of the applyFormatting method to the message processing function, restoring proper variable handling in the Typebot flow.

File-Level Changes

Change Details Files
Bound applyFormatting to the service instance to preserve context.
  • Replaced unbound method reference with a bound version
  • Ensured ‘this’ correctly refers to the service when applyFormatting is invoked
src/api/integrations/chatbot/typebot/services/typebot.service.ts

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @matheusfterra - I've reviewed your changes - here's some feedback:

  • Instead of binding this.applyFormatting on each call, consider binding it once in the constructor to avoid repeated function creation.
  • You could also define applyFormatting as an arrow method in the class so it automatically retains the correct this context without needing manual binding.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Instead of binding `this.applyFormatting` on each call, consider binding it once in the constructor to avoid repeated function creation.
- You could also define `applyFormatting` as an arrow method in the class so it automatically retains the correct `this` context without needing manual binding.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

@JrStarkmidia JrStarkmidia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esse correção é exatamente o que preciso para os meu bots funcionarem novamente.

@DavidsonGomes DavidsonGomes changed the base branch from main to develop June 23, 2025 18:31
@DavidsonGomes DavidsonGomes merged commit a7badb9 into EvolutionAPI:develop Jun 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants