-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Correção do envio de variáveis pelo typeboy #1624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ssar-mensagens-com-variáveis Fix Typebot formatting function
Reviewer's GuideThe PR fixes a context-binding issue by passing a bound version of the applyFormatting method to the message processing function, restoring proper variable handling in the Typebot flow. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @matheusfterra - I've reviewed your changes - here's some feedback:
- Instead of binding
this.applyFormatting
on each call, consider binding it once in the constructor to avoid repeated function creation. - You could also define
applyFormatting
as an arrow method in the class so it automatically retains the correctthis
context without needing manual binding.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Instead of binding `this.applyFormatting` on each call, consider binding it once in the constructor to avoid repeated function creation.
- You could also define `applyFormatting` as an arrow method in the class so it automatically retains the correct `this` context without needing manual binding.
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Esse correção é exatamente o que preciso para os meu bots funcionarem novamente.
Atualmente quando no fluxo do typebot tem o envio de alguma variável, a mensagem não é enviada.
Com essa correção a mensagem é enviada normalmente.
Summary by Sourcery
Bug Fixes: