Skip to content

add unreadMessages in the response #1626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fernandeshenrique15
Copy link

@fernandeshenrique15 fernandeshenrique15 commented Jun 19, 2025

the original code was always sending 0, I added it to the select to get the information that is already in the database and include it in the response


O código original estava sempre enviando 0, adicionei no select para pegar a informação que já está no banco e incluir na resposta

Summary by Sourcery

Bug Fixes:

  • Populate unreadCount from Chat.unreadMessages in the SQL select instead of hardcoded zero

Copy link
Contributor

sourcery-ai bot commented Jun 19, 2025

Reviewer's Guide

The PR augments the channel startup flow by including the actual unread message count from the database in the response instead of always returning zero.

ER diagram for Chat table including unreadMessages

erDiagram
    CHAT {
        int id
        string name
        datetime createdAt
        int unreadMessages
        %% ... other fields ...
    }
    MESSAGE {
        int id
        int chatId
        %% ... other fields ...
    }
    CHAT ||--o{ MESSAGE : has
Loading

Class diagram for updated ChannelStartupService response

classDiagram
    class ChannelStartupService {
        +getChannels()
    }
    class Contact {
        +windowExpires
        +windowActive
        +lastMessage
        +unreadCount
        +isSaved
    }
    ChannelStartupService --> Contact : returns array of
    %% Note: unreadCount is now set from unreadMessages in DB
Loading

File-Level Changes

Change Details Files
Fetch and return real unread message count
  • Add “Chat.unreadMessages” to the SELECT clause
  • Replace hardcoded unreadCount: 0 with contact.unreadMessages in mapping
src/api/services/channel.service.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @fernandeshenrique15 - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant