Skip to content

Patch for broken ICC profile in PNG files #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mqualmann opened this issue Dec 16, 2018 · 3 comments
Closed

Patch for broken ICC profile in PNG files #597

mqualmann opened this issue Dec 16, 2018 · 3 comments
Milestone

Comments

@mqualmann
Copy link

We have been notified of a problem with digiKam writing metadata to PNG files, after which the ICC profile is broken.

https://bugs.kde.org/show_bug.cgi?id=401970

Exiv2 uses a fixed profile name "ICC PROFILE" with 11 characters + zero separator. The profile name can vary between 1-79 characters. Also a warning of the libpng with wrong ICC profile CRC checksum fixes this patch.

Maik
pngIccProfileName.txt

@D4N
Copy link
Member

D4N commented Dec 16, 2018

Please open a pull request.

Thanks!

@clanmills clanmills added this to the v0.27.1 milestone Dec 16, 2018
@clanmills
Copy link
Collaborator

Thanks for letting us know about this.

We're in "code freeze" for v0.27 which we expect to release on 28 December 2018. We're planning quarterly "dot" releases for v0.27 during 2019 and 2020. I'd like to defer this patch for v0.27.1 which is scheduled for 31 March 2019.

@piponazo piponazo mentioned this issue Dec 25, 2018
piponazo added a commit that referenced this issue Jan 25, 2019
@piponazo
Copy link
Collaborator

Fixed in #618. I'll apply the changes into master too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants