Skip to content

Support built-in ID type serialization in GraphQLServerRequest #1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Support built-in ID type serialization in GraphQLServerRequest #1952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ae5eb2
add ID serialization
T45K Apr 13, 2024
1ad4023
add ID serialization test
T45K Apr 14, 2024
dd91c1e
Merge remote-tracking branch 'origin/master' into support_ID_in_Graph…
T45K Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...c/main/kotlin/com/expediagroup/graphql/server/types/serializers/AnyNullableKSerializer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.expediagroup.graphql.server.types.serializers

import com.expediagroup.graphql.generator.scalars.ID
import kotlinx.serialization.KSerializer
import kotlinx.serialization.descriptors.SerialDescriptor
import kotlinx.serialization.descriptors.buildClassSerialDescriptor
Expand Down Expand Up @@ -41,6 +42,7 @@ object AnyNullableKSerializer : KSerializer<Any?> {
is Number -> JsonPrimitive(value)
is Boolean -> JsonPrimitive(value)
is String -> JsonPrimitive(value)
is ID -> JsonPrimitive(value.value)
else -> JsonNull
}

Expand Down
15 changes: 15 additions & 0 deletions ...-server/src/test/kotlin/com/expediagroup/graphql/server/types/GraphQLServerRequestTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

package com.expediagroup.graphql.server.types

import com.expediagroup.graphql.generator.scalars.ID
import kotlinx.serialization.encodeToString
import kotlinx.serialization.json.Json
import org.junit.jupiter.api.Test
Expand Down Expand Up @@ -51,6 +52,20 @@ class GraphQLServerRequestTest {
assertEquals(expectedJson, Json.encodeToString(request))
}

@Test
fun `verify complete serialization including ID`() {
val request = GraphQLRequest(
query = "query FooQuery(\$input: ID) { foo(\$input) }",
operationName = "FooQuery",
variables = mapOf("input" to ID("1"))
)

val expectedJson =
"""{"query":"query FooQuery(${'$'}input: ID) { foo(${'$'}input) }","operationName":"FooQuery","variables":{"input":"1"}}"""

assertEquals(expectedJson, Json.encodeToString(request))
}

@Test
fun `verify batch request serialization`() {
val request = GraphQLBatchRequest(
Expand Down