Skip to content

fix: abstract classes should generate interface #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2019

Conversation

dariuszkuc
Copy link
Collaborator

Fixes: #220

@codecov
Copy link

codecov bot commented May 13, 2019

Codecov Report

Merging #221 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #221   +/-   ##
=========================================
  Coverage     98.43%   98.43%           
- Complexity      178      179    +1     
=========================================
  Files            57       57           
  Lines           574      574           
  Branches         98       99    +1     
=========================================
  Hits            565      565           
  Misses            4        4           
  Partials          5        5
Impacted Files Coverage Δ Complexity Δ
...otlin/com/expedia/graphql/generator/TypeBuilder.kt 100% <100%> (ø) 20 <0> (+1) ⬆️
...dia/graphql/generator/filters/superclassFilters.kt 100% <100%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 514ac52...58f086e. Read the comment docs.

@tapaderster tapaderster merged commit a1c8743 into ExpediaGroup:master May 13, 2019
@dariuszkuc dariuszkuc deleted the fix_abstract_interface branch May 13, 2019 18:56
@smyrick smyrick added changes: patch Changes require a patch version type: bug Something isn't working labels May 13, 2019
dariuszkuc added a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes: patch Changes require a patch version type: bug Something isn't working
Development

Successfully merging this pull request may close these issues.

Generate both interface and type from abstract class
3 participants