Skip to content

Update Documentation for Attribute Pass-Through forms #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: stability-old
Choose a base branch
from
Open

Update Documentation for Attribute Pass-Through forms #81

wants to merge 1 commit into from

Conversation

jcogs-design
Copy link
Contributor

@jcogs-design jcogs-design commented Jun 6, 2020

Overview

These documentation edits complement the proposed changes to the form_declaration function in Functions.php

They provide updated instructions concerning how to 'pass through' FORM attributes via tag parameters.

The pass through function is available to any tag that uses the form_declaration function to draw its opening <FORM> tag. I think all the cases covered by this are included in this documentation update: AFAIK the Comment form does not use this function and so does not benefit from these changes.

Resolves #441.

Nature of This Change

  • 🐛 Fixes a bug
  • 🚀 Implements a new feature
  • 🛁 Rewrites existing documentation
  • 💅 Fixes coding style
  • 🔥 Removes unused files / code

Related Application Change

Application Pull Request: ExpressionEngine/ExpressionEngine#443

These documentation edits complement the proposed changes to the `form_declaration` function in `Functions.php`

They provide updated instructions concerning how to 'pass through' FORM attributes via tag parameters.

The pass through function is available to any tag that uses the form_declaration function to draw its opening `<FORM>` tag.  I think all the cases covered by this are included in this documentation update: AFAIK the `Comment` form does not use this function and so does not benefit from these changes.
@jcogs-design
Copy link
Contributor Author

Associated with ExpressionEngine/ExpressionEngine#443

Bump? Or just delete? Seems pointless to have had it in limbo for so long (almost 2 years).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants