Skip to content

Pandas 0.21.0 Breaks Many of the Tests #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
danielsclint opened this issue Dec 11, 2017 · 2 comments
Closed

Pandas 0.21.0 Breaks Many of the Tests #108

danielsclint opened this issue Dec 11, 2017 · 2 comments

Comments

@danielsclint
Copy link

The time comparisons get broken in 0.21.0:

  • cannot set a Timedelta with a non-timedelta

Need to look at the Pandas changelog and see what happened.
e-lo pushed a commit that referenced this issue Jan 26, 2018
@e-lo
Replaces transitfeed with partridge for GTFS Support
169b3eb 
Primary Change:

* replaces TransitFeed with Partridge Fixes #85

Features:    
  
* Script and tests to expose `calculate_cost` function.   
* Update Travis CI configurations to use miniconda   

Cleanup:  

* Return the proper value for get_stop_times. (fixes #109) .   
* Clean-up tests to take advantage of pytest fixtures.    
* Pandas 0.21.1 breaks things, so put a max version on the setup (#108)
danielsclint pushed a commit to danielsclint/fast-trips that referenced this issue Jan 27, 2018
Address Pandas upgrade issues. (Fast-Trips#108)
9081a9b
danielsclint pushed a commit to danielsclint/fast-trips that referenced this issue Jan 27, 2018
Travis config change for Pandas (Fast-Trips#108)
76c45b8
@danielsclint
Copy link
Author

Pandas 0.21.* changed the way the sum() aggregation functions worked on empty DataFrames. See Pandas Issues:

These fixes were somewhat reverted in Pandas 0.22.*. I added an updated version specification for the requirements.txt and .travis.yml file.

danielsclint pushed a commit to danielsclint/fast-trips that referenced this issue Jan 27, 2018
Set the flag properly. (Fast-Trips#108)
7682ac0
danielsclint pushed a commit to danielsclint/fast-trips that referenced this issue Jan 27, 2018
One more update location (Fast-Trips#108)
b74e124
danielsclint pushed a commit to danielsclint/fast-trips that referenced this issue Jan 27, 2018
Update mapping. (Fast-Trips#108)
157acd8
@e-lo
Copy link
Member

e-lo commented Feb 7, 2018

This is working well on Travis

@e-lo e-lo closed this as completed Feb 7, 2018
e-lo pushed a commit that referenced this issue Aug 9, 2018
@e-lo
Set the flag properly. (#108)
3b2386d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@e-lo @danielsclint