Skip to content

Fix: typo in type definition file #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,15 @@ For full documentation visit [https://docs.flagsmith.com/clients/javascript/](ht

Please read [CONTRIBUTING.md](https://gist.github.com/kyle-ssg/c36a03aebe492e45cbd3eefb21cb0486) for details on our code of conduct, and the process for submitting pull requests to us.

### Development

1. Install Node >= v14.4
1. Clone the repo
1. Install dependencies: `npm install`
1. Generate files: `npm run build`
1. Make your code changes
1. Ensure the project builds with `npm run build` and all tests are passing with `npm run test` before submitting a pull request

## Getting Help

If you encounter a bug or feature request we would like to hear about it. Before you submit an issue please search existing issues in order to prevent duplicates.
Expand Down
2 changes: 1 addition & 1 deletion lib/flagsmith/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "flagsmith",
"version": "9.2.0",
"version": "9.2.1",
"description": "Feature flagging to support continuous development",
"main": "./index.js",
"module": "./index.mjs",
Expand Down
2 changes: 1 addition & 1 deletion lib/react-native-flagsmith/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-native-flagsmith",
"version": "9.2.0",
"version": "9.2.1",
"description": "Feature flagging to support continuous development",
"main": "./index.js",
"repository": {
Expand Down
8 changes: 6 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
"generatetypes": "curl https://github.com/raw/Flagsmith/flagsmith/refs/heads/main/sdk/evaluation-context.json -o evaluation-context.json && npx quicktype -o evaluation-context.ts --src-lang schema --just-types --no-prefer-types --nice-property-names evaluation-context.json && rm evaluation-context.json",
"postinstall": "patch-package",
"prepublish": "npx in-publish && npm run build || echo",
"test": "jest --env=jsdom"
"test": "jest --env=jsdom",
"checknodeversion": "npx ls-engines"
},
"repository": {
"type": "git",
Expand Down Expand Up @@ -79,5 +80,8 @@
"react-native-sse": "^1.1.0",
"reconnecting-eventsource": "^1.5.0"
},
"types": "./index.d.ts"
"types": "./index.d.ts",
"engines": {
"node": ">= 14.14"
}
}
2 changes: 1 addition & 1 deletion test/types.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {IFlagsmith} from '../types';
describe('Flagsmith Types', () => {

// The following tests will fail to compile if any of the types fail / expect-error has no type issues
// Therefor all of the following ts-expect-errors and eslint-disable-lines are by design
// Therefore all of the following ts-expect-errors and eslint-disable-lines are intentional
test('should allow supplying string generics to a flagsmith instance', async () => {
const { flagsmith, } = getFlagsmith({ });
const typedFlagsmith = flagsmith as IFlagsmith<"flag1"|"flag2">
Expand Down
2 changes: 1 addition & 1 deletion types.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export type DynatraceObject = {
}

export interface IFlagsmithFeature<Value = IFlagsmithValue> {
id: numbers
id: number;
enabled: boolean;
value: Value;
}
Expand Down