-
Notifications
You must be signed in to change notification settings - Fork 19
add support for defmt #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
That you for the PR. I'm not yet familiar with |
From my side I think it's a good addition. |
For more context defmt is developed under the kurling-rs project by ferrous systems. Advantages
Disadvantages/Risks
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha, I made a draft for implementing defmt
as well, but did not had the time to make a proper PR out of it. 😀
So I took the opportunity to look over your implantation :)
LGTM
Co-authored-by: Fabian <[email protected]>
Tests are failing. Looks like some undefined references in the |
It seems like only windows is failing and the linux build is successful. This might be because It might just be that defmt does not support windows. |
It does support Windows, just not non-embedded targets (knurling-rs/defmt#463). I am surprised the unit tests ran on Linux at all! I pushed a change to skip the defmt feature for the unit tests. |
This pull-request adds optional support for
defmt
.defmt
, like this crate aims to solve a problem in the core library, namely the code-size of the formatting logic.