Add support Telegram Sticker .tgs in Lottie Integration
#659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dungngminh
requested review from
wasabeef,
AlexV525 and
lcdsmao
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #659 +/- ##
=======================================
Coverage 97.55% 97.55%
=======================================
Files 21 21
Lines 819 819
=======================================
Hits 799 799
Misses 20 20 ☔ View full report in Codecov by Sentry. |
AlexV525
reviewed
Feb 16, 2025
dungngminh
force-pushed
the
main
branch
3 times, most recently
from
da1a9cf to
5f3c681
Compare
|
@AlexV525 I noticed a problem when generating the example files because it was changing the format code, I rolled back to old example code and added changed code lines with my added assets |
Merged
AlexV525
added a commit
that referenced
this pull request
Mar 2, 2025
## 5.10.0 **Feature** - [#659](#659) Add support Telegram Sticker `.tgs` in Lottie Integration. by [@dungngminh](https://github.com/dungngminh) **Bug fix** - [#653](#653) Constraints `dart_style` to `>=2.3.7`. by [@AlexV525](https://github.com/AlexV525) - [#656](#656) Add missing parameters in Lottie integration from lottie 3.0.0. by [@dungngminh](https://github.com/dungngminh) - [#658](#658) Update required dart version. by [@koji-1009](https://github.com/koji-1009)
bluesky950520
added a commit
to bluesky950520/flutter_gen-edit
that referenced
this pull request
Mar 11, 2025
## 5.10.0 **Feature** - [#659](FlutterGen/flutter_gen#659) Add support Telegram Sticker `.tgs` in Lottie Integration. by [@dungngminh](https://github.com/dungngminh) **Bug fix** - [#653](FlutterGen/flutter_gen#653) Constraints `dart_style` to `>=2.3.7`. by [@AlexV525](https://github.com/AlexV525) - [#656](FlutterGen/flutter_gen#656) Add missing parameters in Lottie integration from lottie 3.0.0. by [@dungngminh](https://github.com/dungngminh) - [#658](FlutterGen/flutter_gen#658) Update required dart version. by [@koji-1009](https://github.com/koji-1009)
1 task
AlexV525
added a commit
that referenced
this pull request
Jul 17, 2025
## What does this change? Generated files are being formatted based on confusing conditions. The PR refactored how we construct the Dart formatter in a more elegant manner. 1. The formatter will try to find a valid Dart SDK constraint from `pubspec.yaml` / `pubspec.lock`. Otherwise, it will fall back to using the current Dart SDK version as the constraint. The behavior is like: 1. When the user is using Dart SDK 3.8.0, `pubspec.yaml` has `^3.4.0`, and `pubspec.lock` resolves `^3.7.0`, the formatter will format like 3.4.0. 2. When the runner is being used for testing purposes, which the specified pubspec file does not contain `environment - sdk` (and likely does not have a `pubspec.lock`), the formatter will format based on the current Dart SDK version. 2. The formatter will try to find a valid page width from `analysis_options.yaml - formatter - page_width` / `pubspec.yaml - flutter_gen - line_length`, then prepend the format width header to make all format tools respect the config. - Fixes #685 (comment) - Fixes #659 (comment) - Fixes #620 ## Type of change - [x] New feature (non-breaking change which adds functionality)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
.tgsfiles can be loaded by providing a special decoder. This MR will support.tgs.Screen.Recording.2025-02-14.at.20.50.07.mp4
Type of change
Please delete options that are not relevant.
Checklist:
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
melos run test)melos run formatto automatically apply formatting)