fix deprecations of zeros #1670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes the case like SciML/DiffEqFlux.jl#592 |
|
should |
Co-authored-by: Carlo Lucibello <[email protected]>
|
I think its also a bit weird that there's an error message about forcing people to use a specific type in |
|
Merging since this is required by sciml |
ven-k
added a commit
to ven-k/Flux.jl
that referenced
this pull request
Aug 16, 2021
[Diff since v0.12.5](FluxML/Flux.jl@v0.12.5...v0.12.6) **Merged pull requests:** - Add grouped convolution (FluxML#1531) (@DhairyaLGandhi) - fix deprecations of zeros (FluxML#1670) (@DhairyaLGandhi) - Add GPU activation tests for grouped conv (FluxML#1672) (@DhairyaLGandhi)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deprecations were incorrect
cc @ChrisRackauckas