Skip to content

Silence some warnings #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2022
+3 −1
Merged

Silence some warnings #383

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41ad20e
quieten some warnings
mcabbott Feb 5, 2022
b2bfa81
warn only on promotion to Float64
mcabbott Feb 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/conv.jl
View file
Original file line number Diff line number Diff line change
@@ -285,8 +285,10 @@ for front_name in (:conv, :∇conv_data, :∇conv_filter,
y::AbstractArray{yT,N}, in1::AbstractArray{T1,N},
in2::AbstractArray{T2,N}, cdims::ConvDims;
kwargs...) where {yT, T1, T2, N}
@warn string("Slow fallback implementation invoked for ", $(string(front_name)), "! ",
if yT == Float64 # warn for Float32 + accidental Float64, but don't print warning for ForwardDiff.Dual
@warn string("Slow fallback implementation invoked for ", $(string(front_name)), "! ",
"You probably don't want this; check your datatypes.") yT T1 T2 maxlog=1
end
$(Symbol("$(front_name)_direct!"))(y, in1, in2, cdims; kwargs...)
end
end