POSIX Simulator: Remove unused __APPLE__ mach_vm.h include #1225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnboiles
changed the title
aggarg
previously approved these changes
Jan 20, 2025
Signed-off-by: Gaurav Aggarwal <[email protected]>
|
aggarg
approved these changes
Jan 21, 2025
kar-rahul-aws
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused
__APPLE__mach_vm.hincludeDescription
Looks like this was left over from #674 but the rest of that code (The
mach_vm_round_page/mach_vm_trunc_pagebits) are no longer in the codebase.Including this file breaks compilation for iOS.
Test Steps
Run the POSIX sim on macOS. It still works!
Checklist: