Gad 3 API changes #1454
Merged
Gad 3 API changes #1454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: A Anunaya <[email protected]> Co-authored-by: Aksh Bansal <[email protected]>
add api for android
|
Congratulations for making your first Pull Request at Fusion!! 🎉 Someone from our team will review it soon. |
|
@arminpatel Can you please complete the PR template?? Help us review the PRs faster. |
Done |
Priyansh61
reviewed
Apr 14, 2024
Comment on lines
50
to
57
| if caretaker.exists(): | ||
| complaints = StudentComplain.get_complaints_by_user(user, 'caretaker') | ||
| user_type = 'caretaker' | ||
| elif supervisor.exists(): | ||
| complaints = StudentComplain.get_complaints_by_user(user, 'supervisor') | ||
| user_type = 'supervisor' | ||
| else: | ||
| complaints = StudentComplain.get_complaints_by_user(user, 'student') |
There was a problem hiding this comment.
Can you please Define the usertype instead of hardcoding them?
| return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST) | ||
|
|
||
| @api_view(['DELETE','PUT']) | ||
| @api_view(['DELTE','PUT']) |
|
Great Job!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue that this pull request solves
Closes: # (issue number)
Proposed changes
Brief description of what is fixed or changed
Types of changes
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that applyScreenshots
No changes in interface