syntax cleanup, set minimum PHP version to 5.6 #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello 👋 Could you update this line to 5.6 so that the build passes? JsonPath-PHP/.github/workflows/php.yml Line 23 in 61bfdd5
Yes. I tried once some time ago but the testing library had been updated and changed quite a bit. I could not make the tests work in the time box I had at the time. Now life has me busy, but I'm open to discussing and reviewing PRs 😃 |
|
PHP version bumped to 5.6 in the workflow file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor syntax cleanup
changed
else iftoelseifadded curly braces to parsed strings
replaced double-quoted strings with single-quoted when parsing not needed
Updated composer to require minimum PHP
5.6, but should we bump this to at least7.x? It would be nice to remove the usage of the now-defunctlist()construct, for example.Overall, very handy little library. Let's keep it fresh.