[dev3] Minor changes for python3 support #1310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make the pwn command show usage if no arguments supplied
The errno library moved out of os and into its own library
Arusekk
approved these changes
May 20, 2019
Arusekk
requested changes
May 20, 2019
|
Looks like this breaks Python2. Separately, @Arusekk, we should probably change the CI to use Python3.7 |
|
Well, as for py2, pip plans to drop its support as soon as it gets EOL'd. But in this case it seems to be a fault of CI |
|
For reference: pypa/pip#6275 We can install separately requirements before installing the project, or not use --editable, or build egg info separately |
Arusekk
approved these changes
Jun 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove downgrade requirement for sortedcontainers and intervaltree.
Change the call to intervaltree's search in elf/elf.py to the new overlap function
Spit out usage text if pwn commandline bin is called without arguments.
With these changes I was able to get it working fine on arch without requiring any downgraded packages or other weird tricks. Not entirely sure if this is python 2 incompatible. From what I can see python2 has errno in its own library, the latest py2 intervaltree has search split into overlap/envelop so I'd imagine its fine.