Skip to content

Conversation

h3o66
Copy link
Member

@h3o66 h3o66 commented Jun 22, 2019

Description

Please include a summary of the change and which issues is fixed

Fixes #2398

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This code follows the style guidelines of this project.
  • I have provided Co-author details below.
  • I have performed a self-review of my own code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked If documentation needs updating.

Provide Github Email

Fill out below info or tick box below:

Co-authored-by: Christian Birk <[email protected]>

@dgibbs64
Copy link
Member

The only issue I see is that the old backups will then be in the wrong directory. I think something needs to be done to migrate them to the new directory.

@h3o66
Copy link
Member Author

h3o66 commented Jul 2, 2019

Added little migration function for this commit

@dgibbs64 dgibbs64 self-requested a review July 4, 2019 11:22
@dgibbs64
Copy link
Member

@h3o66 Need permission to this one as well please. In fact please could you check all outstanding PR's 👍

@h3o66
Copy link
Member Author

h3o66 commented Aug 25, 2019

@h3o66 Need permission to this one as well please. In fact please could you check all outstanding PR's

is there already

@dgibbs64 dgibbs64 changed the title refactor(backup) unify backup dir on all configs refactor(backup): unify backupdir on all configs Aug 27, 2019
@dgibbs64 dgibbs64 merged commit 20473df into GameServerManagers:develop Aug 27, 2019
@h3o66 h3o66 deleted the refactor/backuppdir branch August 27, 2019 16:00
@dgibbs64 dgibbs64 added this to the v19.10.0 milestone Sep 17, 2019
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants