Skip to content

Conversation

Frisasky
Copy link
Contributor

@Frisasky Frisasky commented Aug 6, 2019

Description

Now doi requires maxplayer to be set to 32, otherwise the server wont work

link: GameServerManagers/Game-Server-Configs#80

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This code follows the style guidelines of this project.
  • I have provided Co-author details below.
  • I have performed a self-review of my own code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked If documentation needs updating.

Provide Github Email

Fill out below info or tick box below:

Co-authored-by: Frisa <[email protected]>
  • I do not wish to provide an email. I am aware this will hide me as the author of this commit.

All pull requests will now be squashed to create a tidy commit history and simplify changelog creation. You can provide either your own email or a GitHub-provided no-reply email.

When a PR is squashed the author becomes the person who squashed the PR. This removes you as the author of your own PR.
The only workaround for this is to add your details as a co-author. More info about co-authors can be found here.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@dgibbs64 dgibbs64 added the type: bug Something isn't working label Aug 23, 2019
@dgibbs64 dgibbs64 changed the title Change default player number of DOI fix(doiserver): now requires maxplayers to be set to 32 Aug 23, 2019
@dgibbs64 dgibbs64 merged commit 43af797 into GameServerManagers:develop Aug 23, 2019
@conventional-release-bot conventional-release-bot bot mentioned this pull request Aug 28, 2019
14 tasks
@dgibbs64 dgibbs64 added this to the v19.10.0 milestone Sep 17, 2019
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
game: Day of Infamy type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants