Skip to content

Conversation

h3o66
Copy link
Member

@h3o66 h3o66 commented Aug 16, 2019

Description

Add new Server Avorion

Fixes #1271

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This code follows the style guidelines of this project.
  • I have provided Co-author details below.
  • I have performed a self-review of my own code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked If documentation needs updating.

Provide Github Email

Fill out below info or tick box below:

Co-authored-by: Christian Birk <[email protected]>
  • I do not wish to provide an email. I am aware this will hide me as the author of this commit.

All pull requests will now be squashed to create a tidy commit history and simplify changelog creation. You can provide either your own email or a GitHub-provided no-reply email.

When a PR is squashed the author becomes the person who squashed the PR. This removes you as the author of your own PR.
The only workaround for this is to add your details as a co-author. More info about co-authors can be found here.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@h3o66 h3o66 added the type: game server request Request for a new server label Aug 16, 2019
@GameServerManagers GameServerManagers deleted a comment Oct 8, 2019
@GameServerManagers GameServerManagers deleted a comment Oct 8, 2019
@Frisasky Frisasky self-requested a review October 9, 2019 09:04
Copy link
Contributor

@Frisasky Frisasky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems you must run this server for once in order to create config file otherwise it would say config file not found?

@h3o66
Copy link
Member Author

h3o66 commented Oct 13, 2019

seems you must run this server for once in order to create config file otherwise it would say config file not found?

yeah i intended this for now like this, but i could do a "fix" to start the server once after the installation to let the server create the config here

@Frisasky
Copy link
Contributor

Frisasky commented Oct 13, 2019

yeah i intended this for now like this, but i could do a "fix" to start the server once after the installation to let the server create the config here

the fix script for kf2 do exact same thing, so just copy and paste was enough i think

another problem is the server did not work with new resource usage monitor function, install with latest develop codebase gives me ps command error when running details command
#2527

@h3o66 h3o66 requested a review from Frisasky October 26, 2019 16:50
@h3o66
Copy link
Member Author

h3o66 commented Oct 26, 2019

since this server has its own init function I used it in the postinstall fix
If someone else wants to test it, feel free to do so.

@dgibbs64 dgibbs64 closed this Nov 15, 2019
@dgibbs64 dgibbs64 reopened this Nov 15, 2019
@GameServerManagers GameServerManagers deleted a comment Nov 26, 2019
@dgibbs64 dgibbs64 changed the title [WIP] feat(newserver): Avorion feat(newserver): Avorion Apr 20, 2020
@dgibbs64 dgibbs64 added this to the v20.2.0 milestone Apr 22, 2020
@dgibbs64 dgibbs64 merged commit 2f9800e into GameServerManagers:develop Apr 22, 2020
@h3o66 h3o66 deleted the feature/avorion branch June 15, 2020 17:24
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: game server request Request for a new server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants