Skip to content

Conversation

Frisasky
Copy link
Contributor

@Frisasky Frisasky commented Oct 5, 2019

Description

According to steamcmd document, the proper way to designate a branch in steamcmd parameter is "-beta branch" rather than simply put “${branch}" variable in parameter

Fixes #2531

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@Frisasky Frisasky requested a review from dgibbs64 October 5, 2019 02:37
@Frisasky Frisasky changed the title Fix branch support [WIP]Fix branch support Oct 5, 2019
@Frisasky Frisasky changed the title [WIP]Fix branch support Fix branch support Oct 5, 2019
@dgibbs64 dgibbs64 merged commit f975d5c into GameServerManagers:develop Oct 6, 2019
@dgibbs64 dgibbs64 changed the title Fix branch support feat(steamcmd):fix branch support Oct 16, 2019
@dgibbs64 dgibbs64 changed the title feat(steamcmd):fix branch support fix(steamcmd): fix beta branch support Oct 16, 2019
@dgibbs64 dgibbs64 added this to the next release milestone Oct 17, 2019
@dgibbs64 dgibbs64 added the type: bug Something isn't working label Oct 17, 2019
@dgibbs64 dgibbs64 changed the title fix(steamcmd): fix beta branch support bug(steamcmd): fix beta branch support Oct 17, 2019
@dgibbs64 dgibbs64 changed the title bug(steamcmd): fix beta branch support fix(steamcmd): fix beta branch support Oct 17, 2019
@Frisasky Frisasky mentioned this pull request Oct 17, 2019
@dgibbs64
Copy link
Member

dgibbs64 commented Oct 17, 2019

Docs need updating for this https://docs.linuxgsm.com/steamcmd/branch

Allows the selection of specific builds of a game server in SteamCMD

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants