Skip to content

Conversation

Frisasky
Copy link
Contributor

@Frisasky Frisasky commented Oct 8, 2019

Description

Thanks for merging it into a branch @dgibbs64 , i wanna reopen the pull request so if anything needs to be changed it can be done here

Fixes #2393

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@Frisasky Frisasky added the type: game server request Request for a new server label Oct 8, 2019
@dgibbs64
Copy link
Member

dgibbs64 commented Oct 8, 2019

I have uploaded the serverfiles again as the server had a binary mismatch and wanted newer versions of the mohaa ded server binary. Should be ready to merge this evening

@dgibbs64 dgibbs64 merged commit 7a3fa84 into develop Oct 13, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/mohaaserver branch October 13, 2019 23:36
@conventional-release-bot conventional-release-bot bot mentioned this pull request Oct 14, 2019
@dgibbs64 dgibbs64 added this to the next release milestone Oct 17, 2019
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: game server request Request for a new server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants