Skip to content

Conversation

GrillGuth
Copy link
Contributor

For Teamspeak3-Servers: Only use the first IP specified within the ts3server.ini file. The IP string is cut off after the first appearance of a comma (IP seperator within ts3server.ini files).

Description

As described inte teamspeak server documentation the voice_ip parameter allows a comma separated IP list. Currently when e.g. "voice_ip=12.345.678.910, 1a23:b456:7891:011::1" is specified which is according to ts standards LinuxGSM will extract "12.345.678.910 1a23b45678910111" as IP string and can not deal with it. As a workaround till more then one IP and IPv6 is supported the IP string should be cut off after the first appearance of a comma.

Fixes #2658

Type of change

  • Bug fix (change which fixes an issue).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

dgibbs64 and others added 2 commits March 24, 2020 22:49
For Teamspeak3-Servers: Only use the first IP specified within the ts3server.ini file. The IP string is cut off after the first appearance of a comma (IP seperator within ts3server.ini files).
@pull-assistant
Copy link

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     Merge branch 'hotfix/v20.1.5'

     Use only first IP for TS3-servers

Powered by Pull Assistant. Last update 9e53770 ... 0feb9cb. Read the comment docs.

@dgibbs64 dgibbs64 changed the title fix: TS3 ip phrasing fix(ts3server): improve ts3 ip parsing Mar 27, 2020
@dgibbs64 dgibbs64 added this to the v20.2.0 milestone Mar 27, 2020
@dgibbs64
Copy link
Member

Good PR thank you

@dgibbs64 dgibbs64 merged commit fed59c9 into GameServerManagers:develop Mar 27, 2020
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants