feat(steamcmd): move steamcmd dir to standard location

[dgibbs64]

Description

After discussion with a Debian maintainer @smcv, some research and testing I have confirmed the standard steamcmd directory. This feature standardises the steamcmd directory with both the apt package and the curl download.

Depending upon which version of the apt package or curl download steamcmd installed, it will use one of several directories.

/home/lgsm/.steam
/home/lgsm/Steam
/home/lgsm/.local/share/Steam
/home/lgsm/steamcmd

Using a workaround highlighted ValveSoftware/steam-for-linux#6976 (comment) by @smcv I have updated the steamcmd installer so SteamCMD will always be the correct latest install directories.

Fixes #[issue]

Type of change

• Bug fix (change which fixes an issue).
• New feature (change which adds functionality).
• New Server (new server added).
• Refactor (restructures existing code).
• Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

• This pull request links to an issue.
• This pull request uses the develop branch as its base.
• This pull request Subject follows the Conventional Commits standard.
• This code follows the style guidelines of this project.
• I have performed a self-review of my own code.
• I have checked that this code is commented where required.
• I have provided a detailed enough description of this PR.
• I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

• User docs: https://github.com/GameServerManagers/LinuxGSM-Docs
• Dev docs: https://github.com/GameServerManagers/LinuxGSM-Dev-Docs

Thank you for your Pull Request!

[pull-assistant]

Best reviewed: commit by commit

---

Optimal code review plan (3 warnings)

     fix(steamcmd): improvements to steamclient.so fix

     if file missing

     libsteam

2

lgsm/functions/fix_ss3.sh 50% changes removed in remove space

     remove space

     added fix to install in consistent location across distro

     changed steamcmd dir

     updated steamdir

     remove legacy steamcmd dir

     added more code to remove legacy directories

     added dev/null for master server

only remove steamcmd dir if new steamcmddir location

...sm/functions/check_steamcmd.sh 50% changes removed in code tidy

     removed verbose

     migrated some fixes

XDG_DATA_HOME

...sm/functions/check_steamcmd.sh 50% changes removed in added missing Steam ...

     prevent check_last_update from restarting server if stopped

     Merge branch 'develop' into feature/steamcmd

     added missing Steam dir

     code tidy

     changed test to pass

Powered by Pull Assistant. Last update d7d17cb ... fa2a900. Read the comment docs.

[dgibbs64]

ValveSoftware/steam-for-linux#6976

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.