Skip to content

Conversation

h3o66
Copy link
Member

@h3o66 h3o66 commented Jan 9, 2022

Description

Give a message to the user, when the password is not long enough

Fixes #3737

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed with enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@h3o66 h3o66 linked an issue Jan 9, 2022 that may be closed by this pull request
@h3o66 h3o66 force-pushed the fix/vh-pwd-message branch from a42c03c to 230e4f7 Compare January 9, 2022 19:11
@dgibbs64 dgibbs64 force-pushed the fix/vh-pwd-message branch from 230e4f7 to 8c11df6 Compare January 9, 2022 21:31
@dgibbs64
Copy link
Member

dgibbs64 commented Jan 9, 2022

Somehow overwritten your changes with the same changes. Please resubmit the PR

@h3o66 h3o66 force-pushed the fix/vh-pwd-message branch from 8c11df6 to a100ecb Compare January 9, 2022 21:38
@h3o66
Copy link
Member Author

h3o66 commented Jan 9, 2022

Somehow overwritten your changes with the same changes. Please resubmit the PR

Forcepushed my changes again with a little formatting change

@dgibbs64 dgibbs64 added this to the v22.1.0 milestone Jan 9, 2022
@dgibbs64 dgibbs64 merged commit 079fe07 into GameServerManagers:develop Jan 9, 2022
@h3o66 h3o66 deleted the fix/vh-pwd-message branch January 9, 2022 21:47
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] VHServer wont start without an error
2 participants