Skip to content

feat(newserver): add Velocity Proxy #3904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

h3o66
Copy link
Member

@h3o66 h3o66 commented Jun 26, 2022

Description

Please include a summary of the change and which issues are fixed.

Fixes #3436

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed with enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@h3o66 h3o66 force-pushed the feature/velocityproxymc branch 2 times, most recently from 2ee08fc to f2cc757 Compare June 26, 2022 21:55
@h3o66
Copy link
Member Author

h3o66 commented Jun 26, 2022

TBD: check if upload of the default config needed or not
TBD2: create new shutdown command "shutdown" to send to console

@h3o66 h3o66 force-pushed the feature/velocityproxymc branch from f2cc757 to 7aa2828 Compare June 27, 2022 18:57
@h3o66
Copy link
Member Author

h3o66 commented Jun 27, 2022

Updated to create the new stop command "shutdown"

@h3o66 h3o66 force-pushed the feature/velocityproxymc branch 3 times, most recently from 0adec9c to 271103c Compare June 27, 2022 19:53
@h3o66
Copy link
Member Author

h3o66 commented Jun 27, 2022

Added port message, config parsing and dependency for java 11

@h3o66 h3o66 force-pushed the feature/velocityproxymc branch from 271103c to 6e36129 Compare June 27, 2022 19:59
@h3o66
Copy link
Member Author

h3o66 commented Jun 27, 2022

Added a bit more of config parsing.
I did not see the need to add the config to our repo, at is created at the first start.

The current latest version does not seem to be a stable one, that is the only curlprint for this.

@h3o66 h3o66 marked this pull request as ready for review June 27, 2022 20:04
@h3o66 h3o66 linked an issue Jun 27, 2022 that may be closed by this pull request
4 tasks
@h3o66 h3o66 added this to the v22.2.0 milestone Jun 27, 2022
@dgibbs64
Copy link
Member

Is this ready to merge?

@h3o66 h3o66 force-pushed the feature/velocityproxymc branch from 6e36129 to 7f7bbb1 Compare August 24, 2022 11:26
@h3o66 h3o66 mentioned this pull request Aug 24, 2022
13 tasks
@h3o66
Copy link
Member Author

h3o66 commented Aug 24, 2022

Is this ready to merge?

From my side this is ready.
Would be good if someone else can test this before this is released.

@dgibbs64 dgibbs64 merged commit bf1fc18 into GameServerManagers:develop Sep 22, 2022
@h3o66 h3o66 deleted the feature/velocityproxymc branch September 22, 2022 20:27
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Server Request] Velocity Proxy for minecraft
2 participants