Skip to content

fix(vints): refactor to fix it when there is no config for the server #3955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

h3o66
Copy link
Member

@h3o66 h3o66 commented Aug 22, 2022

Description

This changes the order of the variables and some default variables for Vintage Story

Fixes #3658

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed with enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

@h3o66 h3o66 added type: bug Something isn't working game: Vintage Story labels Aug 22, 2022
@h3o66 h3o66 added this to the v22.2.0 milestone Aug 22, 2022
@h3o66 h3o66 changed the title Merge branch 'release/v22.1.0' into develop fix(vints): refactor to fix it when there is no config for the server Aug 22, 2022
@dgibbs64 dgibbs64 merged commit 920657e into GameServerManagers:develop Aug 23, 2022
@h3o66 h3o66 deleted the fix/vints-config-3658 branch August 24, 2022 11:23
@h3o66 h3o66 linked an issue Sep 3, 2022 that may be closed by this pull request
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
game: Vintage Story type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]vintsserver monitor ip unavailable
2 participants