Ensure external vectors are scaled via -i #5291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See GenericMappingTools/pygmt#1313 for details. This PR ensures the record-by-record reading of external vectors have any adjustments set via -i applied.
|
I have now added the complement to this for the full dataset ingestion via vectors and the above Mississippi plot works for me. Please look for any other oddities. |
PaulWessel
changed the title
|
Looks good to me. I don't see any side-effects on the PyGMT side. |
seisman
approved these changes
Jun 3, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See GenericMappingTools/pygmt#1313 for details. This PR ensures the record-by-record reading of external vectors have any adjustments set via -i applied. I will add a similar fix for the table-reading later today.