Add workflow for uploading baseline images as a release asset

[maxrjones]

Description of proposed changes

Based on GenericMappingTools/pygmt#1317

Closes #5724

Reminders

• Make sure that your code follows our style. Use the other functions/files as a basis.
• Add tests for new features or tests that would have caught the bug that you're fixing.
• Describe changes to function behavior and arguments in a comment below the function declaration.
• If adding new functionality, add a detailed description to the documentation and/or an example.

[seisman]

Looks good but I can't test it

[maxrjones]

@seisman, do you think having this as a separate workflow is better than zipping up the files as part of the build-release script and adding the upload step to the draft-release workflow? I am undecided about which would be preferable.

[seisman]

zipping up the files as part of the build-release script and adding the upload step to the draft-release workflow

Uploading tarball in the draft-release workflow sounds a good idea to me, but we can't create the baseline image tarball in the build-release.sh script, because the script is run by Paul, not by any workflows.

[maxrjones]

zipping up the files as part of the build-release script and adding the upload step to the draft-release workflow

we can't create the baseline image tarball in the build-release.sh script, because the script is run by Paul, not by any workflows.

I don't understand this point. The workflow commands are bash, and build-release.sh is a bash script so the code in

gmt/.github/workflows/release-baseline-images.yml

Lines 31 to 39 in aa93c06

	mkdir baseline-images
	mkdir baseline-images/test
	mkdir baseline-images/examples
	mkdir baseline-images/scripts
	cp -r test/baseline/* baseline-images/test
	cp doc/examples/images/*.ps baseline-images/examples
	cp doc/scripts/images/*.ps baseline-images/scripts
	zip -r baseline-images baseline-images/ -x "*.dvc"
	shasum -a 256 baseline-images.zip

would be possible to adapt to work in build-release.sh.

[seisman]

When making a release, Paul runs the build-release.sh script to build the source tarballs, create the macOS bundle and copy the source tarballs and macOS bundle to the GMT FTP server.

The script needs many commands like cmake and sphinx-build. We can improve the script so that it can create the tarball of baseline images, but if we want to run the script in CI, we have to install all the required commands.

[maxrjones]

Right, it would need to be run by Paul and placed on the GMT FTP server with the other files. @PaulWessel, any opinions on whether to bundle and upload the baseline images manually as part of build-release.sh along with the other files or keep it separate as currently written in this PR?

[PaulWessel]

I think it is probably fine as you have it in the CI - maybe one day the rest will follow.

[PaulWessel]

In terms of release timing: I have all Saturday and maybe a short slice on Sunday but then it is in the car with the Watts and off to some serious hiking in the Lake District. Probably not going to be productive at some mountain cabin. Then on Tuesday I will be dropped off in Newcastle and take the train to Edinburgh for a Uni visit and talk. Then a 6 hour train trip back on Wednesday. So let's see if we can get lots of stuff done before then - otherwise the release may be end of next week.

[maxrjones]

In terms of release timing: I have all Saturday and maybe a short slice on Sunday but then it is in the car with the Watts and off to some serious hiking in the Lake District. Probably not going to be productive at some mountain cabin. Then on Tuesday I will be dropped off in Newcastle and take the train to Edinburgh for a Uni visit and talk. Then a 6 hour train trip back on Wednesday. So let's see if we can get lots of stuff done before then - otherwise the release may be end of next week.

Sounds fun!
I can update the changelog, citation info, and test with PyGMT tomorrow AM EST. I think this is ready if I can get an approval on it.