Update grdimage required arguments #8694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
reviewed
Feb 19, 2025
|
Can I merge this? BTW, I've just updated the rst file directly to master and looks fine. |
|
@joa-quim is it ok to merge this? |
|
This is not right. At #L223 it's inserting the -J in the middle of -I description. |
Ok. I see. Should it be in Line 231 (just before |
|
Yep, alphabetic order. |
|
Now it is line 231. BTW, why there is "-" after the "J"? |
Don't remember. |
joa-quim
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
grdimagemodule does not require the-Jargument.Modify the file so that
-Jappears among the optional arguments when one typesgmt grdimagein the terminal.I also remove
Jin#define THIS_MODULE_NEEDS.On my pc it works fine. But I'm not sure I did it right.
Then I will modify the rst file.