-
Notifications
You must be signed in to change notification settings - Fork 228
Set bash to be default shell for Github Actions CI #1037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaves a few lines off the .github/workflows/*.yaml files. See https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#defaultsrun.
seisman
approved these changes
Mar 12, 2021
FYI: 47 test failures on GMT dev (after gmt-themes branch merge) (see https://github.com/GenericMappingTools/pygmt/runs/2092112323?check_suite_focus=true#step:14:1224) 🙂
I'll merge this PR in now and focus on #1036 a bit more tonight. Suggest that we deal with the test failures after v0.3.1 release, just need to ignore the test failure notification for some more days. |
5 tasks
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…ls#1037) Shaves a few lines off the .github/workflows/*.yaml files. See https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#defaultsrun.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
maintenance
Boring but important stuff for the core devs
skip-changelog
Skip adding Pull Request to changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Shaves a few lines off the .github/workflows/*.yaml files. See https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#defaultsrun.
Also secretly testing how many tests break with merge of gmt-themes branch upstream
Fixes #
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version