Skip to content

Update fig.basemap, fig.subplot and fig.wiggle baseline images for GMT 6.2.0rc2 #1291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 25, 2021

Conversation

willschlitzer
Copy link
Contributor

@willschlitzer willschlitzer commented May 25, 2021

Update the baseline images in several module tests. Per the discussion in #1289, this is one of two pull requests and does not cover the updates to test_text.py.

Addresses #1289

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added the maintenance Boring but important stuff for the core devs label May 25, 2021
@willschlitzer willschlitzer added this to the 0.4.0 milestone May 25, 2021
@willschlitzer willschlitzer self-assigned this May 25, 2021
@willschlitzer willschlitzer mentioned this pull request May 25, 2021
13 tasks
@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2021

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
modified pygmt/tests/baseline/test_basemap_polar.png
modified pygmt/tests/baseline/test_subplot_autolabel_margins_title.png
modified pygmt/tests/baseline/test_subplot_basic_frame.png
modified pygmt/tests/baseline/test_subplot_clearance_and_shared_xy_axis_layout.png
modified pygmt/tests/baseline/test_subplot_direct.png
modified pygmt/tests/baseline/test_wiggle.png

None

Image diff(s)

Added images

Modified images

Path Old New
test_basemap_polar.png
test_subplot_autolabel_margins_title.png
test_subplot_basic_frame.png
test_subplot_clearance_and_shared_xy_axis_layout.png
test_subplot_direct.png
test_wiggle.png

Report last updated at commit 39061bd

@willschlitzer willschlitzer marked this pull request as ready for review May 25, 2021 08:17
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @willschlitzer! There's a few changes I'd recommend reverting since they don't affect the tests (not sure why the hashes are different, maybe due to slightly different systems). Otherwise, there's just one xfail to remove in test_basemap.py and we should be good to merge.

Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I'll merge this in (using admin privilleges) and we can handle #1292 to get all the tests passing again!

@weiji14 weiji14 changed the title Update baseline images for GMT 6.2.0rc2 Update fig.basemap, fig.subplot and fig.wiggle baseline images for GMT 6.2.0rc2 May 25, 2021
@weiji14 weiji14 merged commit 0afaf93 into master May 25, 2021
@weiji14 weiji14 deleted the gmt62rc2-test-updates branch May 25, 2021 09:50
@weiji14 weiji14 added the skip-changelog Skip adding Pull Request to changelog label Jun 20, 2021
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
…T 6.2.0rc2 (GenericMappingTools#1291)

Fix broken tests on GMT 6.2.0rc2 for fig.basemap, fig.subplot and fig.wiggle.

* update basemap dvc images
* update subplot dvc images
* update wiggle dvc images
* remove xfail from test_basemap_polar()

Co-authored-by: Wei Ji <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants