-
Notifications
You must be signed in to change notification settings - Fork 228
Update fig.basemap, fig.subplot and fig.wiggle baseline images for GMT 6.2.0rc2 #1291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
None Image diff(s)Added imagesModified images
Report last updated at commit 39061bd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @willschlitzer! There's a few changes I'd recommend reverting since they don't affect the tests (not sure why the hashes are different, maybe due to slightly different systems). Otherwise, there's just one xfail
to remove in test_basemap.py
and we should be good to merge.
Co-authored-by: Wei Ji <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, I'll merge this in (using admin privilleges) and we can handle #1292 to get all the tests passing again!
…T 6.2.0rc2 (GenericMappingTools#1291) Fix broken tests on GMT 6.2.0rc2 for fig.basemap, fig.subplot and fig.wiggle. * update basemap dvc images * update subplot dvc images * update wiggle dvc images * remove xfail from test_basemap_polar() Co-authored-by: Wei Ji <[email protected]>
Update the baseline images in several module tests. Per the discussion in #1289, this is one of two pull requests and does not cover the updates to
test_text.py
.Addresses #1289
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version