Skip to content

Conversation

seisman
Copy link
Member

@seisman seisman commented Apr 9, 2023

Description of proposed changes

Following NEP29 policy where Python 3.8 will be dropped on or after Apr 14, 2023.

Changes in this PR:

  • Update the minimum Python version in ci_tests.yaml
  • Update the minimum Python version in ci_tests_legacy.yaml
  • Update the minimum Python version in the compatibility table in README
  • Update the minimum Python version in doc/install.rst
  • Update the Python version in the requires-python field and remove the related entry from classifiers in pyproject.toml.
  • Update branch protection rules

Supersedes PR #1676 and afed7c9

Fixes #2300.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added this to the 0.10.0 milestone Apr 9, 2023
@seisman seisman added deprecation Deprecating a feature needs review This PR has higher priority and needs review. labels Apr 9, 2023
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Apr 9, 2023
@seisman seisman merged commit d2b0c39 into main Apr 10, 2023
@seisman seisman deleted the nep29/python3.8 branch April 10, 2023 08:04
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Apr 10, 2023
seisman added a commit that referenced this pull request Feb 5, 2024
Following [SPEC 0](https://scientific-python.org/specs/spec-0000/) policy where
Python 3.9 should be dropped in 2023 quarter 4.

Supersedes PR #2487.

Address #2863.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Deprecating a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NEP29: Don't drop Python 3.8 support until Google Colab upgrades to Python 3.9 or above?
2 participants