Skip to content

Conversation

seisman
Copy link
Member

@seisman seisman commented Sep 1, 2023

The pygmt.test() function is not used and can be removed.

Closes #2633

@seisman seisman changed the title Remove the unused pygmt.test function Remove the unused pygmt.test() function Sep 1, 2023
@seisman seisman added the maintenance Boring but important stuff for the core devs label Sep 1, 2023
@seisman seisman added this to the 0.10.0 milestone Sep 1, 2023
@seisman
Copy link
Member Author

seisman commented Sep 1, 2023

I'm fine with merging this PR before or after the v0.10.0 release.

@michaelgrund
Copy link
Member

I'm fine with merging this PR before or after the v0.10.0 release.

Would merge it before.

@michaelgrund michaelgrund added the final review call This PR requires final review and approval from a second reviewer label Sep 1, 2023
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, do we label this under maintenance or deprecation?

@seisman seisman added deprecation Deprecating a feature and removed maintenance Boring but important stuff for the core devs labels Sep 1, 2023
@seisman
Copy link
Member Author

seisman commented Sep 1, 2023

"Deprecation" makes more sense.

@weiji14 weiji14 merged commit 884e67e into main Sep 1, 2023
@weiji14 weiji14 deleted the remove-test branch September 1, 2023 06:34
weiji14 added a commit that referenced this pull request Sep 1, 2023
@yvonnefroehlich yvonnefroehlich removed the final review call This PR requires final review and approval from a second reviewer label Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Deprecating a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the pygmt.test function from pygmt/__init__.py?
4 participants