Use unique earth_age tiles in test_dataset_to_strings_with_none_values #3200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
added
maintenance
michaelgrund
approved these changes
Apr 24, 2024
yvonnefroehlich
approved these changes
Apr 24, 2024
seisman
removed
the
final review call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test_dataset_to_strings_with_none_valuestest was added in #3174 when addressing issue #3170.To reproduce issue #3170, the test must delete the tiles from the cache and download them again. The original test usually works but may fail when running multiple tests parallelly (xref #3193). Two tests may download the same file at the same time or
whichmay find the local file but then it is deleted when reading.This PR fixes the problem by using two unique tiles that are not used in other tests. These two tiles are chosen because they have the smallest sizes (the original jp2 files on the GMT data server are smaller than 1 KB).