Skip to content

Conversation

yvonnefroehlich
Copy link
Member

@yvonnefroehlich yvonnefroehlich commented Jul 21, 2024

Description of proposed changes

Currently I am confused by the grant numbers for the support of PyGMT.

(I) At https://www.pygmt.org/dev/overview.html#about we write:

The project was started in 2017 by Leonardo Uieda and Paul Wessel (the co-creator and main developer of GMT) at the University of Hawaiʻi at Mānoa. The development of PyGMT has been supported by NSF grants OCE-1558403 (https://www.nsf.gov/awardsearch/showAward?AWD_ID=1558403) and EAR-1948603 (https://www.nsf.gov/awardsearch/showAward?AWD_ID=1948602).

As you can see, the link for EAR-1948603 points actually to EAR-1948602. And there seem to be no grant EAR-1948603, as the link https://www.nsf.gov/awardsearch/showAward?AWD_ID=1948603 outputs "No such award found.".

(II) Looking at the acknowledgements of https://figshare.com/articles/presentation/Geospatial_analysis_and_visualization_with_PyGMT_SciPy_2022_/20483793:

The development of PyGMT has been supported by NSF grants OCE-1558403 (https://www.nsf.gov/awardsearch/showAward?AWD_ID=1558403) and EAR-1948603 (https://www.nsf.gov/awardsearch/showAward?AWD_ID=1948602). M.R. Jones has been supported by EAR-1948602 (https://nsf.gov/awardsearch/showAward?AWD_ID=19486020). ...

There is very likely a typo in the link https://nsf.gov/awardsearch/showAward?AWD_ID=19486020; probably it should be without the last "0", i.e. https://nsf.gov/awardsearch/showAward?AWD_ID=1948602. And again, the link for EAR-1948603 is pointing to EAR-1948602.

Maybe @maxrjones or @leouieda can help here, please.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash command is:

  • /format: automatically format and lint the code

@yvonnefroehlich yvonnefroehlich added question Further information is requested documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Jul 21, 2024
@seisman seisman changed the title Unclear grant numbers for the support of PyGMT Fix the grant numbers for the support of PyGMT Jul 22, 2024
@seisman seisman added this to the 0.13.0 milestone Jul 22, 2024
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed question Further information is requested final review call This PR requires final review and approval from a second reviewer labels Jul 22, 2024
@seisman seisman merged commit d7560fa into main Jul 23, 2024
@seisman seisman deleted the fix-grant-number branch July 23, 2024 06:40
@yvonnefroehlich
Copy link
Member Author

@GenericMappingTools/pygmt-maintainers we should also update the Notes of the Zenodo upload
at https://zenodo.org/records/11062720

The development of PyGMT has been supported by NSF grants OCE-1558403 and EAR-1948603.

@weiji14
Copy link
Member

weiji14 commented Jul 28, 2024

@GenericMappingTools/pygmt-maintainers we should also update the Notes of the Zenodo upload at https://zenodo.org/records/11062720

The development of PyGMT has been supported by NSF grants OCE-1558403 and EAR-1948603.

Cool, I've updated the note on the v0.12.0 record:

image

And also included NSF grant EAR-1948602 in the Funding field (couldn't find OCE-1558403 for some reason).

image

@yvonnefroehlich
Copy link
Member Author

yvonnefroehlich commented Jul 29, 2024

And also included NSF grant EAR-1948602 in the Funding field (couldn't find OCE-1558403 for some reason).

Hm. Interesting. Also tried to find it via the search on Zenodo, but not successful. Maybe we can add it as custom grant:

add_OCE_grant_pygmt_to_zenodo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants