Skip to content

Let grdcut() accept xarray.DataArray as input #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 21, 2020
Merged

Let grdcut() accept xarray.DataArray as input #541

merged 2 commits into from
Jul 21, 2020

Conversation

seisman
Copy link
Member

@seisman seisman commented Jul 21, 2020 •
edited
Loading

Description of proposed changes

Let grdcut accept xarray.DataArray as input, and also updates the two tests, with dataarray in, and file/dataarray output.

Fixes #496.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

@seisman seisman marked this pull request as ready for review July 21, 2020 20:37
@seisman seisman requested a review from weiji14 July 21, 2020 20:39
weiji14
weiji14 approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @seisman, looks good! Just one minor suggestion to use a fixture, but otherwise I'm happy with it.

P.S. Will be focusing on thesis writing the rest of the day.

@seisman seisman added the feature Brand new feature label Jul 21, 2020
@seisman seisman added this to the 0.2.x milestone Jul 21, 2020
@seisman seisman merged commit eb93372 into master Jul 21, 2020
@seisman seisman deleted the grdcut-xarray branch July 21, 2020 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiji14 weiji14 weiji14 approved these changes

Assignees
No one assigned
Labels
feature Brand new feature
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

Let grdcut support xarray.DataArray as inputs
2 participants
@seisman @weiji14