Skip to content

Mark xarray shading test fail for GMT<=6.1.1 #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Conversation

seisman
Copy link
Member

@seisman seisman commented Oct 15, 2020

Description of proposed changes

The xarray shading issue in #364 was fixed by upstream GMT in GenericMappingTools/gmt#4328.

This PR updates the pytest xfail condition, so that the xarray shading test is expected to xfail only for GMT<=6.1.1.

Closes #364.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Oct 15, 2020
@seisman seisman added this to the 0.2.1 milestone Oct 15, 2020
@seisman seisman requested a review from weiji14 October 15, 2020 00:47
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! In terms of issues #364 and #638, do we want to:

  1. have this PR close them automatically (and have users install the GMT dev version using conda install -c conda-forge/label/dev gmt since Bump GMT from 6.2.0.dev1+07a16c2 to 6.2.0.dev2+8a4275f conda-forge/gmt-feedstock#108 is merged).
  2. wait until GMT 6.2.0 is released then manually close those two issues?

Also, what do you think about making a PyGMT v0.2.1 release soon-ish? There's a lot of good new documentation!

@seisman
Copy link
Member Author

seisman commented Oct 15, 2020

  1. have this PR close them automatically (and have users install the GMT dev version using conda install -c conda-forge/label/dev gmt since conda-forge/gmt-feedstock#108 is merged).
  2. wait until GMT 6.2.0 is released then manually close those two issues?

Both are OK for me. I think closing them now makes us easy to track high-priority issues.

Also, what do you think about making a PyGMT v0.2.1 release soon-ish? There's a lot of good new documentation!

Yes, that's why I want to push the merging of PRs like #480 and #482.

@seisman
Copy link
Member Author

seisman commented Oct 15, 2020

BTW, I'm not sure if #638 is fixed by the upstream GMT updates. We need feedbacks from the user.

@seisman seisman merged commit a6a0919 into master Oct 15, 2020
@seisman seisman deleted the grid-shading branch October 15, 2020 01:27
@weiji14
Copy link
Member

weiji14 commented Oct 15, 2020

  1. have this PR close them automatically (and have users install the GMT dev version using conda install -c conda-forge/label/dev gmt since conda-forge/gmt-feedstock#108 is merged).
  2. wait until GMT 6.2.0 is released then manually close those two issues?

Both are OK for me. I think closing them now makes us easy to track high-priority issues.

BTW, I'm not sure if #638 is fixed by the upstream GMT updates. We need feedbacks from the user.

Let's just close #364 for now (but keep it pinned), and leave #638 open for a bit longer

Also, what do you think about making a PyGMT v0.2.1 release soon-ish? There's a lot of good new documentation!

Yes, that's why I want to push the merging of PRs like #480 and #482.

Cool, I've got a lot on my plate but will try and get on top of those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grdimage shading fails for xarray input
2 participants