Skip to content

Fix Github to GitHub #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 22, 2020
Merged

Fix Github to GitHub #659

merged 2 commits into from
Oct 22, 2020

Conversation

seisman
Copy link
Member

@seisman seisman commented Oct 21, 2020 •
edited
Loading

Description of proposed changes

We should use "github" or "GitHub", not "Github".

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

@seisman seisman requested a review from weiji14 October 21, 2020 03:38
@seisman seisman added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Oct 21, 2020
@seisman seisman added this to the 0.2.1 milestone Oct 21, 2020
weiji14
weiji14 approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Somehow I never noticed GitHub was camel case until now!

@seisman seisman merged commit 3b64511 into master Oct 22, 2020
@seisman seisman deleted the typo/github branch October 22, 2020 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiji14 weiji14 weiji14 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Milestone
0.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@seisman @weiji14