Skip to content

Add i686-pc-windows-gnu CI #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Sep 3, 2023

Sorry it took so long.
Addresses #946

Because of new versions of sha1-asm there are not code changes required.

@Byron
Copy link
Member

Byron commented Sep 4, 2023

Thanks a lot, it's appreciated no matter when it happens :).

It seems with this PR gitoxide will not accidentally break due to SHA1-asm anymore, while also providing a platform to test this kind of build by default. That's fantastic, as it roots out (one of ?) the last strangeness around builds that I remember.

@Byron Byron merged commit 72328a3 into GitoxideLabs:main Sep 4, 2023
@mati865 mati865 deleted the i686-mingw-ci branch September 4, 2023 06:01
@Byron Byron mentioned this pull request Sep 4, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants