fix: NetBSD doesn't have st_mtime_nsec and st_ctime_nsec
#1170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have no NetBSD environment to test it though 😆. |
It has `st_mtimensec` and `st_ctimensec` instead. * https://man.netbsd.org/NetBSD-8.0/stat.2 * https://docs.rs/libc/0.2/x86_64-unknown-netbsd/libc/struct.stat.html#structfield.st_mtimensec * https://docs.rs/libc/0.2/aarch64-unknown-netbsd/libc/struct.stat.html#structfield.st_mtimensec * https://docs.rs/libc/0.2/x86_64-unknown-netbsd/libc/struct.stat.html#structfield.st_ctimensec * https://docs.rs/libc/0.2/aarch64-unknown-netbsd/libc/struct.stat.html#structfield.st_ctimensec
weihanglo
changed the title
st_mtime_nsecst_mtime_nsec and st_ctime_nsec
Byron
approved these changes
Dec 10, 2023
There was a problem hiding this comment.
Oh my!
I wasn't aware gitoxide is somehow pulled into the rust build chain!
This means that in theory, I would have to test all targets that Rust is being built on to prevent this from happening again. I guess it's possible, but I don't know about feasibility.
After merging, I will create a new patch release which maybe fixes the issue for you downstream, or at least makes it fixable.
|
A |
|
Thanks for the release! I don't think it tests all targets, but at this tiers with host build tools :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: NetBSD doesn't have
st_mtime_nsecandst_ctime_nsecIt has
st_mtimensecandst_ctimensecinstead.This blocks
cargosubmodule sync in rust-lang/rust btw: rust-lang/rust#118765 (comment)