filter refs by spec #526

Byron · 2022-09-05T11:13:46Z

Tasks

refactor: git-sec remove tag from Access, make a check that only returns on Option, ignoring Deny.
quick-error replaced with thiserror where it made a difference

Predecessor

Many of the error definitions changed from tuple types to structs.

Some errors change shape which makes this a breaking change.

Turns out backslashes are escaped, which can make it into the error and look strange there.

It's a clear case of over-engineering and it didn't prove to be useful at all.

It's now included by default even though it's only used for a single error type. The reasoning is that `git-sec` is used within a tree that uses `thiserror` anyway, so no need to optimize compile times for the case where it doesn't.

…se. (#450)

As this error is only used for `Permission`, it's clear that it contains a `Permission` instance.

…ncy. (#450) This also removes the need for the `Permission` field as it's clear that only `Forbid` variants can produce it.

It was somewhat specific to being printed in the error scenario, and not general purpose at all.

Byron added 23 commits September 5, 2022 19:12

replace quick-error with thiserror (#450)

bc45906

chore!: replace quick-error with thiserror (#450)

5a74999

Many of the error definitions changed from tuple types to structs.

chore!: remove quick-error in favor of thiserror (#450)

9c8a36f

Some errors change shape which makes this a breaking change.

adjust to changes in git-object (#450)

9aadac3

chore!: replace quick-error with thiserror (#450)

4d6ce80

adjust to changes in git-validate (#450)

4eac45f

chore!: replace quick-error with thiserror (#450)

725210d

thanks clippy

1d85564

adjust to changes in git-ref (#450)

296f23f

fix docs (#450)

dad9cbe

fix journey tests (#450)

5ac6fee

fix windows tests (#450)

140e690

Turns out backslashes are escaped, which can make it into the error and look strange there.

change!: Remove Access without replacement. (#450)

0f0bca3

It's a clear case of over-engineering and it didn't prove to be useful at all.

refactor (#450)

129bc87

change!: remove thiserror optional feature. (#450)

ac3823d

It's now included by default even though it's only used for a single error type. The reasoning is that `git-sec` is used within a tree that uses `thiserror` anyway, so no need to optimize compile times for the case where it doesn't.

feat: Permissions::check_opt() for those who don't need an error ca…

515e521

…se. (#450)

adapt to changes in git-sec (#450)

0ce21b1

change!: permission::Error<R> with only one generic parameter (#450)

51c721c

As this error is only used for `Permission`, it's clear that it contains a `Permission` instance.

Manually implement permission::Error to save on thiserror depende…

b42a64d

…ncy. (#450) This also removes the need for the `Permission` field as it's clear that only `Forbid` variants can produce it.

change!: remove Perrmission::fmt() (Display) (#450)

33f8b92

It was somewhat specific to being printed in the error scenario, and not general purpose at all.

feat: Permission::is_allowed() as convenience method (#450)

fe24b41

adjust to changes in git-sec (#450)

d6ef2ce

refactor (#450)

9e4e4c4

Byron merged commit e10554d into main Sep 11, 2022

Byron deleted the filter-refs branch September 11, 2022 02:43

This was referenced Sep 12, 2022

filter refs by spec #532

Merged

filter refspecs in git-repository #534

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

filter refs by spec #526

filter refs by spec #526

Byron commented Sep 5, 2022 •

edited

Loading

filter refs by spec #526

filter refs by spec #526

Conversation

Byron commented Sep 5, 2022 • edited Loading

Tasks

Next

Predecessor

Byron commented Sep 5, 2022 •

edited

Loading