Skip to content

proper tree entry sorting #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 11, 2023
Merged

proper tree entry sorting #849

merged 2 commits into from
May 11, 2023

Conversation

Byron
Copy link
Member

@Byron Byron commented May 11, 2023

Fix tree-entry sorting once and for all.

Tasks

  • test to reproduce the issue
  • a fix

@Byron Byron linked an issue May 11, 2023 that may be closed by this pull request
1 task
Byron added 2 commits May 11, 2023 16:33
This means tree entries are compared as if they had a / appended to it.
@Byron Byron merged commit e3b146f into main May 11, 2023
@Byron Byron deleted the fix-848 branch May 11, 2023 16:25
EliahKagan added a commit to EliahKagan/gitoxide that referenced this pull request Oct 14, 2024
This updates the "git_cmp_c" and "git_cmp_rs" links in the
`gix_diff::tree::function::diff` documentation comment.

- The significant change is to the "git_cmp_rs" link (the second
  link), which accounts for how files have renamed and how code has
  been moved, and also changed in GitoxideLabs#849 to fix issue GitoxideLabs#848.

  This hyperlink change completes the third task listed in GitoxideLabs#1627.

- The other change is to update the "git_cmp_c" link at the same
  time. That code has not changed, and this is just referring to a
  later commit (the current tip of the master branch in git/git).

  The reason to also do this change is to make it easier to verify,
  both now and for anyone reading the documentation, that that link
  remains current.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong entry order in tree object
1 participant