Skip to content

Conversation

pix
Copy link
Contributor

@pix pix commented Sep 7, 2017

I modified the default config to allow splitting of choco_packages.

This idea is to allow to pass options to each package directly (to disallow checksums, specify package options, etc.)

Copy link
Collaborator

@Svieg Svieg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me and @obilodeau talked about putting those packages in the default profile and install them using the package option in the profile. What do you think?

@pix
Copy link
Contributor Author

pix commented Sep 7, 2017

I thought about it but I found that the "package" section of the profile a little cumbersome to use.
I find "package": [{"package": "thunderbird"}], is a little bit verbose.

"package": [
    // Feels hackish
    {"package": "npcap --package-parameters /winpcap_mode=yes"}
    // Feels verbose
    {"package": "thunderbird", parameters: ["/winpcap_mode=yes"], ignore_checksum: true} 
    // Incompatible
    "npcap --package-parameters /winpcap_mode=yes"
],

But I'm not opposed to migrating completly.
Also the patchset now allows to not install chocolatey, maybe moving to profile-example.js and adding a enable_chocolatey (do we need to install it if we don't need packages ?, how to install it without installing any packages ?)

@obilodeau
Copy link
Contributor

obilodeau commented Sep 7, 2017

The profiles API is marked as experimental on purpose. The package: [ {"package", ... }, ...] is a redundancy I want to get rid of but due to conference release deadlines, I didn't do.

Proposal:

"packages": [ "thunderbird", "npcap --package-parameters /winpcap_mode=yes"];

and we keep "choco_packages" as is for now.

p.s.: note the s on packages

@pix pix mentioned this pull request Sep 14, 2017
@pix pix closed this Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants