Skip to content

Needs an update with new WABT #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RReverser opened this issue May 5, 2020 · 1 comment · Fixed by #23 or #26
Closed

Needs an update with new WABT #22

RReverser opened this issue May 5, 2020 · 1 comment · Fixed by #23 or #26
Assignees

Comments

@RReverser
Copy link
Contributor

SIMD opcodes have been renumbered in the spec - see WebAssembly/simd#129 - and updated in WABT.

We need to regenerate JS with a newest WABT and publish a new version.

I've tried to make a PR, but it only changed README because dist is not part of the repo, so it's probably best that this change is done by whoever has publish access.

RReverser added a commit that referenced this issue May 5, 2020
It's somewhat easier to use from JavaScript, makes wabt a regular npm dependency, and, what's even more important, is more frequently updated than WABT pre-built binaries.

It's not yet updated to fix #22 for us, but should be on the next nightly build - feel free to either merge this now or keep open until it gets updated.
@surma surma closed this as completed in #23 May 5, 2020
@RReverser RReverser reopened this May 5, 2020
@RReverser
Copy link
Contributor Author

Sigh, magical keywords :) Reopened for tracking the update.

RReverser added a commit that referenced this issue May 12, 2020
Upstream issue AssemblyScript/wabt.js#13 has been resolved and new nightlies are being released again, so we can close #22.
@surma surma closed this as completed in #26 May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants