Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.

sort imports acording to the Google style #254

Merged
merged 1 commit into from
May 25, 2016

Conversation

aozarov
Copy link
Contributor

@aozarov aozarov commented May 24, 2016

No description provided.

@ludoch
Copy link
Contributor

ludoch commented May 24, 2016

Which tool did you use?

@gregw
Copy link
Contributor

gregw commented May 24, 2016

@aozarov I think it is a good idea to get all the code reformatted like this. However once done, we need very good style configurations for eclipse and IDEA, so that reformats will produce no changes at all.

@aozarov
Copy link
Contributor Author

aozarov commented May 24, 2016

@ludoch , I used the internal sort tool

find . -name '*.java' | xargs sort_java_imports.py 

@gregw, indeed. see google-java-format
This is the rule for sort order: https://google.github.io/styleguide/javaguide.html#s3.3.3-import-ordering-and-spacing
Both eclipse and intelliJ have options to specify this order (I can share my settings with you if you want). Also, they have an option to cleanup unused import statements.

@aozarov
Copy link
Contributor Author

aozarov commented May 24, 2016

Also, looks like sort order would be part of the google-java-format once this bug is fixed.

@ludoch
Copy link
Contributor

ludoch commented May 25, 2016

lgtm

@ludoch ludoch merged commit 92e279e into GoogleCloudPlatform:async-support May 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants