Fixes #262 - Integration testing more stable in maven. #283
Conversation
…ven. + Forces maven-failsafe-plugin in parent (with version) + Moves jetty9-compact-base tests back into src/test/java + Renames integration tests from *Test.java to *IT.java to better conform to new recommendations from maven-failsafe-plugin (convention over configuration!)
|
This PR isn't sane (yet), a followup commit (to correct checkstyle warnings) is due for this PR. |
|
Google Style Guide is incompatible with maven-failsafe-plugin.
We'll need an exception. |
…ava-format-1.0-all-deps.jar
|
@aozarov do you want me to alter the Checkstyle xml? |
| @@ -68,12 +62,18 @@ | |||
| import javax.servlet.http.HttpServletRequest; | |||
| import javax.servlet.http.HttpSession; | |||
|
|
|||
| import static org.easymock.EasyMock.createMock; | |||
There was a problem hiding this comment.
Not sure why this was changed. static imports should be at the top according to the Google style guide
Please do. it should be fine to have an IT suffix for integration tests and exempt it from checkstyle. |
|
@aozarov why didn't the |
|
Ah, import management is currently broken in the Also, looks like there's a |
+ Fixed import order issues + Added checkstyle/checkstyle-suppressions.xml + Updated root pom.xml to use new suppressions techniques in a way that's friendly to a maven reactor build
| "http://www.puppycrawl.com/dtds/suppressions_1_1.dtd"> | ||
|
|
||
| <suppressions> | ||
| <suppress files="[a-zA-Z0-9]*IT.java" checks="AbbreviationAsWordInName"/> |
There was a problem hiding this comment.
Nit, should it be prefixed with [/\\]test[/\\]src[/\\]java[/\\] (also for the other IT, Test checks)?
There was a problem hiding this comment.
I would vote for the simpler form, as maven is free to copy/move files around into the /target/ (aka ${project.build.directory}) directory, which checkstyle also looks inside of.
There was a problem hiding this comment.
I can live with it though I wish we could avoid being lenient where we shouldn't.
better conform to new recommendations from maven-failsafe-plugin
(convention over configuration!)