Skip to content

fix: run go get in conformance action #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2020
Merged

fix: run go get in conformance action #33

merged 1 commit into from
Oct 2, 2020

Conversation

hdp617
Copy link
Contributor

@hdp617 hdp617 commented Oct 2, 2020 •
edited
Loading

When using the action in other functions frameworks' CI workflows, the comformance tool is not local so go install would fail with the error

can't load package: package github.com/GoogleCloudPlatform/functions-framework-conformance/client: cannot find package "github.com/GoogleCloudPlatform/functions-framework-conformance/client" in any of:
	/opt/hostedtoolcache/go/1.13.15/x64/src/github.com/GoogleCloudPlatform/functions-framework-conformance/client (from $GOROOT)
	/home/runner/go/src/github.com/GoogleCloudPlatform/functions-framework-conformance/client (from $GOPATH)

Using go get will both download and install the conformance tool.

@hdp617 hdp617 marked this pull request as draft October 2, 2020 20:55
@hdp617 hdp617 marked this pull request as ready for review October 2, 2020 21:30
@hdp617 hdp617 requested a review from roffjulie October 2, 2020 21:42
@roffjulie roffjulie merged commit bfa74d7 into master Oct 2, 2020
@roffjulie roffjulie deleted the hdp617-patch-1 branch October 2, 2020 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@roffjulie roffjulie roffjulie approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hdp617 @roffjulie